[Cypress Updates] App analytics updates #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 21, 2024 16:50
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
ps48
approved these changes
Dec 4, 2024
paulstn
reviewed
Dec 4, 2024
| @@ -432,11 +435,12 @@ describe('Viewing application', () => { | |||
| cy.get('[data-test-subj="app-analytics-configTab"]').click(); | |||
| cy.get('select').select(visOneName); | |||
| cy.intercept('PUT', `**/api/observability/application`).as('selectUpdate'); | |||
| cy.wait('@selectUpdate') | |||
| cy.wait(2000); // despite the previous wait grabbing the call that updates the panel select, it doesn't appear without this | |||
There was a problem hiding this comment.
Do we know why the tests now work without this?
There was a problem hiding this comment.
The test now reloads the home page after changing the availability which also makes the applications update properly
paulstn
reviewed
Dec 4, 2024
| @@ -479,8 +483,7 @@ describe('Separate from other plugins', () => { | |||
| cy.visit( | |||
| `${Cypress.env('opensearchDashboards')}/app/observability-dashboards#/` | |||
| ); | |||
| cy.get('[data-test-subj="operationalPanelsActionsButton"]', { timeout: timeoutDelay }).click(); | |||
| cy.get('[data-test-subj="addSampleContextMenuItem"]', { timeout: timeoutDelay }).click(); | |||
| cy.get('.euiButtonContent').contains('Add samples').click(); | |||
There was a problem hiding this comment.
Does this element have a data-test-subj?
paulstn
reviewed
Dec 4, 2024
TackAdam
approved these changes
Dec 4, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-2261-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9c94bc96f38bf048e36f417e51e6710f85bb5e7f
# Push it to GitHub
git push --set-upstream origin backport/backport-2261-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.xThen, create a pull request where the |
ritvibhatt
added a commit
to ritvibhatt/dashboards-observability
that referenced
this pull request
Dec 5, 2024
* update cypress testing for app analytics Signed-off-by: Ritvi Bhatt <[email protected]> * replace wait Signed-off-by: Ritvi Bhatt <[email protected]> * change action menu for metrics Signed-off-by: Ritvi Bhatt <[email protected]> * update snapshots Signed-off-by: Ritvi Bhatt <[email protected]> * wait for service entities and trace groups to load Signed-off-by: Ritvi Bhatt <[email protected]> * load deleted applications Signed-off-by: Ritvi Bhatt <[email protected]> * remove deleted applications from table without reload Signed-off-by: Ritvi Bhatt <[email protected]> * fix deleting saved visualizations Signed-off-by: Ritvi Bhatt <[email protected]> * type in applications to delete Signed-off-by: Ritvi Bhatt <[email protected]> --------- Signed-off-by: Ritvi Bhatt <[email protected]> Co-authored-by: Ritvi Bhatt <[email protected]> (cherry picked from commit 9c94bc9)
TackAdam
added a commit
that referenced
this pull request
Dec 6, 2024
* update cypress testing for app analytics Signed-off-by: Ritvi Bhatt <[email protected]> * replace wait Signed-off-by: Ritvi Bhatt <[email protected]> * change action menu for metrics Signed-off-by: Ritvi Bhatt <[email protected]> * update snapshots Signed-off-by: Ritvi Bhatt <[email protected]> * wait for service entities and trace groups to load Signed-off-by: Ritvi Bhatt <[email protected]> * load deleted applications Signed-off-by: Ritvi Bhatt <[email protected]> * remove deleted applications from table without reload Signed-off-by: Ritvi Bhatt <[email protected]> * fix deleting saved visualizations Signed-off-by: Ritvi Bhatt <[email protected]> * type in applications to delete Signed-off-by: Ritvi Bhatt <[email protected]> --------- Signed-off-by: Ritvi Bhatt <[email protected]> Co-authored-by: Ritvi Bhatt <[email protected]> (cherry picked from commit 9c94bc9) Co-authored-by: Adam Tackett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Visualization action menu:
Issues Resolved
#1886
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.